Hacker News Reader

Comment by msgodel | Hacker News Reader

It looks to me like they close nearly 30 PRs every day. That's kind of amazing.

I'm no fan of Microsoft but that's a massive maintenance burden. They must have multiple people working on this full time.

View on HN

If you examine the merged PR's - the overwhelming majority are from Microsoft employees. Meanwhile, community contributions sit and rot.

I thought they just open sourced this? Was there enough time to start reviewing community contributions?

How would I be able to examine the PRs to verify this?

Look at the first comment in the PR, it will have a badge "This user is a member of the Microsoft organization". Alternatively, look at the release notes on the website, any non-Microsoft contributions are listed at the bottom.

Right, but how to do that for thousands of PRs to see that there's a bias? I assume it's a ton of work.

Why not sample 20 and see if you can spot a trend?

Because I studied statistics.

You can get the JSON from like,

gh pr list --repo microsoft/vscode --state merged --limit 1000 --json author,mergedAt,title

Then you can do:

And see there's only 63 authors and > 90% of the merged PRs are from Microsoft (which.. fair, it's their product).

I think the signal is strong enough that you can legitimately reach the same conclusion by mk 1 eyeball.

NOTE: I'm not criticising, it's a Microsoft-driven project and I am fine with that. The _do_ merge things from "random" contributors (yay) but they are overwhelmingly things that a) fix a bug while b) being less than 5 lines of code. If that is your desired contribution then things will go well for you and arguably they do well at accepting such. But they are very unlikely to accept a complex or interesting new feature from an outsider. All of this is seems totally reasonable and expected.

There aren't that many Microsoft employees, it took me a couple minutes to memorize the team.

Of course the majority are from Microsoft, they do seem to merge in a fair amount of PRs from the community though.

Yet the Settings UI is still a nonsensical mess.

How is it a nonsensical mess? It’s clean, searchable, allows to fallback to json..

I get it might not be perfect, but "nonsensical mess" is maybe in bad faith here.

Valid question. There's some area where the text of the setting's state is the opposite of what the checkbox shows. I'll try to dig up a screen shot.

Historically, setting syntax colors has sucked too, but I don't remember the current state of that.

Reply on news.ycombinator.com