> we've always told people `#define xfree(p) do { free(p); p = NULL; } while (0)` is a bad pattern

Have we? Why?