Nothing in the legal terms explicitly prevents your employees from using my designs for other purposes. If you leak my IP and I find out 13 months later, your terms prevent me from seeking damages because you only cover 12 months from manufacturing.
I like that you have an NDA that I can opt in to, but you should be offering the NDA by default when I upload the files. I should not have to go looking for it in your documentation.
Edit: I realize that there is also limited protection and a lot of risk using a Chinese manufacturer. But requiring source files makes it much, much, easier to look at my design, recognize what it's for, and reproduce it, or at least copy the innovative parts of my design.