You seem to have missed that he wasn't popular on those things that didn't change. Healthcare in particular was low, immigration was at best middling.

> And previously, voters’ trust in his economic management was the one thing propping him up. But the Iran war destroyed it

Americans are surprisingly sane when polled on individual issues, but the political system doesn't generally reflect that.