Disadvantage #1 seems unnecessary. Instead of this:
s = sdscat(s,"Some more data");
Why not do this? sdscat(&s,"Some more data");
The latter would make the use-after-free error they're describing impossible. (Disadvantage #2, changing one reference but not others, would remain. And callers would still need to check for NULL if they intend to handle ENOMEM gracefully.)I assert there's no meaningful performance difference between the two.