One issue with that is that it gives government incentives to keep people in their vices. As an imperfect example, police departments that plan on funding a significant part of their budget from speed tickets aren't encouraged to educate people against speeding or fix unreasonable speed limits.

It's also not that stable of a form of government revenue. Vices tend to be inelastic, but luxury spending will often drop precipitously in a downturn.