Of course, that was 50 years ago- as the phrase has gotten recycled for initiatives like the War on Drugs, it has lost that nuance and context, and sounds more like some zero-tolerance, overly militant government program (which parts of it were). Many or most Americans would agree with you that "War on X" needs to go, including me.
According to Wikipedia[1], the "war on crime" was used by Hoover in the '30s.
here it is on youtube: https://www.youtube.com/watch?v=luMdJAia-bw
Mostly any kid smoking small amount of marijuana. Being free of drugs wont necessary help you, because law enforcement so much power, that they can take away your property even if you have done nothing wrong. And you can still get stopped and searched for drugs for no reason.