[0] an attitude I find myself unthinkingly adopting when doing reviews.
[0] an attitude I find myself unthinkingly adopting when doing reviews.
hard to ask for it without it seeming completely petty, particularly when everything else is perfect. it does represent a minor improvement.
Consider it this way: natively speaking English means you have domain knowledge, sharing that domain knowledge should feel no different from pointing out mistakes in other domains. If someone gets English wrong, that's no different from getting, say, VAT calculation wrong.
Maybe I'm just assuming everyone already handles mistakes in other domains with tact and respect.
Also, it's a matter of proportion. If a function name is extremely misleading that's different from a function name just using an awkward synonym, just as a broken piece of code is different from dodgy indentation. You'll want to fix either problem eventually, but the immediate repercussions are quite different (serious bug vs minor annoyance, basically).
I think we're generally in agreement – I was trying to keep the focus on things which can be reasonably be considered objectively wrong and keeping the degree of wrongness in mind when deciding how to handle it. If you're on the low end of that scale, it's probably not a good use for everyone's time in a code-review session unless it happens a lot.
Naming is important. Bad function names are a bug in the API, just like any other API bug.
Non-native speakers frequently struggle naming things even more than native speakers, especially when they have to deal with a problem domain for the first time.
Just like any other mistake, bad function names usually aren't intentional -- often quite the opposite. I remember struggling with naming business domain related functions and variables in the first booking system I worked on, especially because the UI wasn't localized into English, so I had no direct reference. Should this class be called Invoice or Bill? Are the terms "netto" and "brutto" commonly used in English as they are in German? What's the proper plural of "index"? And so on.
Having tactful help from a native speaker can be a huge advantage.
As an aside, I recently saw a job listing that included the requirement to be able to "defend your code in reviews" - I would say that's an environment where reviews probably aren't positive experiences.
As an intern, I've had many times where I'd say "I did it this way using A B and C, is that the best way? Are there any improvements you'd suggest?" after completing work. But in a more senior position, you probably don't want people second guessing / not really understanding these decisions.