allset_

Style is much more than formatting. It's best practices around naming, when and how to add comments, and how to write clear and maintainable code.

I think I disagree with the emphasis on asking questions. Not because questions shouldn't be asked, but because they should be asked much earlier in the process than the PR stage. Every feature should at a minimum have a brief doc for the requirements and high level design. If you haven't read that and are reviewing the PR for anything other than style, you need to take a step back and go read that doc first.

In my opinion, the levels are:

1. Barely-existent review: The PR author is the SME, I'm only reviewing and LGTMing this because peer review is needed to submit the change. I might notice a typo or something along those lines, and will call out if they're being lazy and skipping tests.

2. Functionality-focused change: Does the code meet the objective and do the tests adequately cover the change?

3. In-depth review: Does the code address the problem in an efficient way that is not likely to cause the team future pain?

How about Signal? It uses phone number as identifier so you keep your contacts list, and the app works with SMS (on Android).

> many applications do not support webauthn, full stop

You don't need the application to, only your IDP. Everything should be SSO from there.

They called them Passkeys. It's FIDO2 with resident keys only AFAIK though https://developer.apple.com/passkeys/

WebAuthn (well, U2F, but that's essentially WebAuthn with a slightly different browser API and WebAuthn is backward compatible with U2F only devices) support has been on the YubiKey since the Neo in 2014 [0]. It's basically impossible to have a YubiKey that does not support WebAuthn. You do not need FIDO2 on-key resident credentials to benefit from WebAuthn.

[0] https://www.yubico.com/blog/neo-u2f-key-apps/

When you do that you're also buying into a phone that will stop receiving security updates sooner since iPhones receive updates for ~5 years after they're released.

Yep. About once a month after I broke something badly or got malware for the millionth time. Shoutout to my friend's dad who worked in IT and gave me their WinXP corporate serial number so I could reinstall without having to phone Microsoft! Still have it memorized to this day.

> I can always go outside to my grill.

That's a privilege a lot of people in cities don't have. I would love to have a gas cook top, but my building is electric only.

Edit: I'm also in the "advanced home cook" category, not a pro.

WebAuthn security keys.

Love the size and weight of my Pixel 4a. I broke the screen on mine a few weeks back, and paid over half the original price of the phone to have it repaired.

5.9in is not small.

> We just need good rules around its use.

Rules change. The people in power change. They may say "fuck those rules" in the future. The only way to prevent abuses like this is to not surveil unnecessarily.

Do they come with ethernet runs to every room? Those walls will murder RF like WiFi.

> Want to hang out with your friends? Good luck on agreeing on a place to rent that's in budget for all of you if you have £1m+ in the bank.

What? Is the wealthier person in this scenario too much of a snob to stay in cheaper accommodations that everyone can afford, or pay a little more than their "fair share" to help book nicer ones that everyone can enjoy?

I would not want to be friends with that person.

Love the Floppotron, glad to see it alive and well! Keep it up!

It gets too hot a couple weeks every year. 90F+ for days and even in the evening it doesn't drop that much which is rough when most people don't have AC.

GitHub already has this, called Verified Mode [1]. It has to be opted into rather than out of though.

[1] https://docs.github.com/en/authentication/managing-commit-si...

I use Tutanota due to its privacy focus. 1€/mo is very affordable.

There's a new(er) fork that doesn't use CGo.

https://github.com/zombiezen/go-sqlite

Isn't the Wireguard implementation in Cilium between nodes only, not workloads (pods)?

No, but clients do advertise how much of the torrent they have, so you can glance at your peer list and if you have 2 peers stuck at 10%... there's a good chance that you won't get more than 10%.

It can be done. It takes a heck of a lot longer than 15s though.

Many commuters in the US spend >30min (often 45+min) in their car in insane traffic. It's not like its all roses to drive to work.

Your cavilier tone here about casually introducing a MiTM threat that many people won't understand to the e2e encrypted messaging ecosystem is pretty disgusting. As others have noted, the issue is that I can't opt out of other people using this which breaks the security guarantees of the chat system.

The messages are encrypted end to end so compromising push notifications doesn't get you anything. That's the problem with this bridge, it adds a new server with access to the unencrypted messages.

72 character lines is very annoying in a modern world. My display is 3440px wide and can easily fit 120 chars if I split it in thirds, the rest is just wasted space. Every terminal and text editor has word wrap now, this isn't a problem anymore. Even on a 1080p screen split it half, 72chars is too few.

If only the hardware compatibility was better. It hasn't worked on my past three laptops.

I see it the opposite way. If a company hires a core maintainer (often the only maintainer), they have huge amounts of power over the direction of the project as they can threaten to fire the maintainer who is now dependent on the company for income.

Contributing improvements externally allows the project to remain independent. And if the maintainer is overburdened they can decline the patches or postpone review. Nobody is forcing them to accept the changes.

The required subscription also means it's useless if they go out of business.