HNHacker News
TopNewBestAskShowJobs

jacobegold

64 karma · joined November 17, 2021

submissionscomments
jacobegold··on How we migrated from CRA to Next.js AppRouter in 5 pull requests
were they stacked tho
jacobegold··on Reorient GitHub pull requests around changesets
I'm keeping an eye on Pierre (https://pierre.co/) as well — not being subject to the whims of GitHub makes for some interesting ideas!
jacobegold··on Reorient GitHub pull requests around changesets
I was lucky enough to work at a company with a great code review tool at one of my first positions -- and I am nowhere near convinced that GH's review interface is the simplest possible.

Of course, everyone (including myself!) is probably biased to think that whatever they are used to is simplest, tbh.

jacobegold··on Reorient GitHub pull requests around changesets
They must have refs on the internal git servers -- they need them for the "force pushed from X to Y" timeline events
jacobegold··on Reorient GitHub pull requests around changesets
How you do PRs is definitely important, and should be part of a company's consideration here, but remember that PRs are already a layer of abstraction over the SCM. Self-hosting Git is definitely not as easy as setting up a GH account.

Not to mention that you get an easy way to spin up your CI/CD workflows in GH Actions (which of course definitely has its own problems, which there was another popular HN post about recently). There's a reason why it's the default for new companies -- if there was something much better, it wouldn't have the market share it does I think. Familiarity coming from OSS is also important.

jacobegold··on Reorient GitHub pull requests around changesets
Not to mention the value of a diff/pull request/changelist/patch/merge request (so many names...) and its corresponding discussion as a historical artifact for your team to reference later on!
jacobegold··on Reorient GitHub pull requests around changesets
GitHub actually stores all the data necessary to do this without changing your ref model as the article suggests — even if you force push, it never garbage collects the commits that the branch used to point to.

I work on a tool that includes a UI for diffing versions of a GitHub PR, but you can totally get the same thing via messing with GitHub.com URLs.

jacobegold··on Reorient GitHub pull requests around changesets
There are tools that solve this problem! I work on one (Graphite), but there's also plenty of others like git-branchless and Sapling. All three of these are inspired by Facebook's internal fork of Mercurial (with Phabricator/"Diffs" for reviewing) -- Google has a similar model with Piper/Critique CLs, with Gerrit as the open source result.
jacobegold··on Reorient GitHub pull requests around changesets
I used to work at FB, and unfortunately the Sapling review client that shows GH PRs has nothing on the the actual internal code review tooling at Facebook (now called Diffs, formerly Phabricator). I miss that tool so much
jacobegold··on Reorient GitHub pull requests around changesets
Large OSS feels like a different use case than the big company one, to be honest -- I think that what maintainers care about is vastly different than what companies do. GitHub feels optimized for the former (OSS) as it is today.
jacobegold··on Reorient GitHub pull requests around changesets
Better tooling is definitely the answer here -- I used to work at Facebook where rebasing dependent patches in Mercurial when you needed to adjust something felt like a first-classed flow, and I'm currently working on a tool that does the same thing, but on top of Git and GitHub.
jacobegold··on Reorient GitHub pull requests around changesets
This is what Facebook did extremely well with Phabricator, which was then open sourced.
jacobegold··on Show HN: Graphite – Stacked Diffs on GitHub
So sorry about that! If you update to the latest version of v1, we added a check to verify your Git version is up to date -- we use a feature from v2.38.

Reach out to me (Jacob Gold) on our Slack Community if you're still seeing this issue. The link's on the Graphite website.

jacobegold··on Building Graphite with Graphite (how I've come to love stacking)
Building Graphite with Graphite is oh so satisfying, but sometimes I forget to look through the lens of someone less familiar with the product! Any users of the tool have interesting thoughts on what we might be able to improve?
jacobegold··on Aurora I/O optimized config saved 90% DB cost
This feels likely!
jacobegold··on The ideal PR is 50 lines long
Wait until you see what the research shows about PR descriptions
jacobegold··on What is a merge queue, and does your team need one?
GitHub's market share percentage is a multiple of AWS's — and also, GitHub is just the beginning for us!
jacobegold··on What is a merge queue, and does your team need one?
What's the difference between a merge queue and a pull queue?
jacobegold··on In Praise of Stacked PRs
But you can still construct stacked PRs out of the 2500-line change even you write it all at once -- just go back and split the changes into a series of PRs that makes sense. Much easier for your reviewers to get through, so it'll be able to ship faster.
jacobegold··on In Praise of Stacked PRs
The advantage of using stacks, though, is that you can keep focus on what you're working on, or even still work on 2-3 things simultaneously but work on multiple dependent pieces of each at once. Maybe I'm biased because I've used this workflow my whole career, but I think everyone can benefit from trying out a stacked PR workflow.

Not to mentioned getting reviews for smaller, atomic changes is just SO much easier. Even on a team where everyone is using a stacked workflow, if anyone submits a larger PR (especially more than a few hundred lines), you can see how the smaller PRs submitted in the same time, often in the same stack, get reviewed much faster.

jacobegold··on Pull Request File Tree Feedback
So funny :) I was on storage but was "moonlighting" on Iris for my last couple months at FB — what a small world!

Feel free to shoot me an email if you don't want to wait, although the list moves fairly quickly these days.

jacobegold··on Pull Request File Tree Feedback
Try out Graphite! Half of us are ex-FB, so we get it.

https://graphite.dev/

jacobegold··on Pull Request File Tree Feedback
Send an email (from the address you use to sign into GitHub!) to jacob@graphite.dev :)
← PreviousPage 2 of 2