1,538 karma · joined January 9, 2009
//! \brief Transport diagnostic wrapper
class TransportDiagnosticWrapper {
(Actually, meaningful one-line comments are a lyric discipline of their own, related to haikus.)Plus one outdated sequence diagram.
"and here is the 1M LOC codebase, which was carefully crafted to avoid using any of the complicated frameworks; all you gotta know is the C standard library".
I invoke Layne's Law and go back to work.
Adding e.g. a symbolic constant is a bet. You win if during the lifetime of the system, you discover that the constant must be changed, and the gain is the time saved by changing it quickly and with few errors. If you never have to change the constant, you lose the time spent on introducing the constant and the time spent on looking up the constant while reading the code.
Most of the rules here are long change (or whatever the financial people call betting on something), except for KISS.
Oh, OS courses at the university... good old time. (Some participants complained that going from zero to bare-metal x86 was too difficult.)
386 has both a segment mechanism and a paging mechanism. The segment mechanism has several luxury features like automatic saving and restoring of task context. It is possible to set up a segment descriptor so that the CPU, when jumping (or faulting) to an address in the segment, will automatically save task state at one address (taken from a register) and restore task state from another address (taken from the descriptor). Ibelieve that's what they use here. Hence, free memory accesses.
Unless the encryption key is guarded by something with SMM privileges -- has that been done?
I usually fail at glass doors when PUSH and PULL labels are transparent so that I read "PUSH" and (reverse) "PULL" simultaneously.
The text looked to me like one could extract all the commands, run them and check their output against the embedded reference output automatically. I don't know, it had such a rigid structure.
On a second look, the output contains timestamps, so what looks like shell output is probably only shell output the author has copied once into their text.