731 karma · joined October 2, 2013
FWIW, Reviewable (https://reviewable.io) follows roughly this design and, after 6 years, it's still a fine system to develop in. It runs on top of Firebase RTDB which takes care of the security rules; if anything, I feel better having all the security rules articulated in one central location (the schema) rather than spread throughout the backend. Communication between client and backend also flows through the database (with very few exceptions), which lets the backend get away with an easy to scale queue-based design.
There are downsides, of course. As many posters alluded to, changing the schema gets tricky. It basically must remain backwards compatible for at least a few releases so as not to inconvenience the users, and some kinds of changes are just not feasible. And yeah, how the client wants to fetch data does affect the schema as well, though in practice I haven't found the impact to be too bad. Also, Reviewable has only one (browser) client, so I don't need to worry about duplicating logic -- I probably wouldn't pick this architecture if multiple clients were a requirement. Putting much of the business logic in a client-side model layer integrated with the database structure actually works out really nicely, though I still struggle with how to efficiently share some of the logic with server-side code.
Overall, I'm satisfied with how things worked out and would definitely consider using a similar architecture again in the right circumstances. The article is right on the money that if you're just getting started on your MVP it's worth thinking about a thin- or no-backend approach.
Reviewable is a bootstrapped code review tool that improves on GitHub PRs. I've been running the company mostly solo for 5+ years and need somebody to take over the core engineering, product management, and ops functions. You must be knowledgeable and excited about code reviews, and able to both plan a product strategy and execute on it. Ultimately, if you're interested and capable, there's a path towards assuming leadership of the business and partnership in the company.
Salary and benefits, US only (for now). Tech stack is Vue/JS, Node/TS, Firebase RTDB, GitHub API, and Docker.
Please get in touch with piotr@reviewable.io if interested in a chat. Thanks!
Reviewable: Reviewable is a peer code review tool for GitHub PRs that makes your workflow simultaneously more efficient and more thorough. Inspired by Google's Critique and launched 6 years ago, it has picked up a dedicated following solely through word of mouth and has made inroads into the enterprise market, particularly in the self-driving car vertical. While GitHub has started improving PR reviews again, they're aiming at an 80% solution leaving a lucrative niche in the other 20% for nimbler, more specialized companies like Reviewable.
Me: I built and have been running Reviewable since inception, mostly solo. I want to find someone to take over leadership of the company and inject new energy and purpose into it, while I get some headspace for new ventures. I'll remain available and involved but step back from the day-to-day decision-making loop.
You: You're passionate about code review and intimately familiar with GitHub. You're a strong engineer with a solid understanding of JavaScript (Vue 2, CSS, Firebase RTDB, Node), not afraid to take over a somewhat idiosyncratic 65+KLoC codebase, and with excellent written communication skills. You don't need anyone to tell you what to do and how to do it, and you're looking to stretch yourself into a leadership position without taking on all the risks of starting something from scratch.
If this sounds like it could be a good fit for you please get in touch with piotr@reviewable.io. Thanks!
[1] https://arstechnica.com/tech-policy/2020/05/twitters-first-f...
Reviewable is a code review tool for GitHub that improves on pull requests. It has seen strong adoption among companies that prioritize thorough but efficient code reviews. The company is bootstrapped and has been profitable for a number of years. I'm now looking for the first full-time hire: somebody who could quickly take the lead on all technical aspects (development [JavaScript, Vue, Node, Firebase RTDB, GitHub API], product, ops, contractor management) and eventually grow into the business role (support, marketing, sales, etc.). The position is fully remote and a great opportunity for a talented software engineer to assume control over a useful product with great growth potential, get their feet wet with a small bootstrapped business without taking on much risk, and learn new skills that may eventually help you start a business of your own! Please email piotr@reviewable.io to start a conversation if you're interested.
"I know there will be significant economic impacts to all our communities and we are looking at steps to help address those challenges."
Doesn't Google Voice solve this problem? Or perhaps there are restrictions I don't know about. Of course, you still have to remember to create a burner phone number before giving out your contact info...
Isn't that what Rollup is for?
GitHub: 31M users
BitBucket: 6M users, 1M orgs
GitLab: 100K orgs
The GitLab number tallies with Emily's answer, which gives me some moderate confidence that these numbers are in the right neighborhood. I'm also going to assume that the users-vs-teams numbers are all in roughly the same proportion.
Based one these numbers it doesn't make much sense to target BitBucket unless either 1) they're growing much faster than GitHub (unlikely) or 2) their customers are a much better fit for Reviewable (possible, but it would have to be a truly significant difference in userbase composition). Targeting GitLab doesn't appear to make sense at all (as a business), though perhaps they're growing fast.
And no, you can't shrink/hide code, other than by re-diffing. What can I say -- it's surprisingly hard to implement and didn't seem worth it.
This seems like a pretty good idea in any case. If the seizing party can't crack the passcode anyway then it's a no-op. If they can then presumably they won't/can't do it right away, so it would add a bit of defense in depth.