HNHacker News
TopNewBestAskShowJobs

piotrkaminski

731 karma · joined October 2, 2013

I run https://reviewable.io. You can reach me at piotr at ideanest dot com.
submissionscomments
piotrkaminski··on Correct Git commits with git-autofixup
<plug>In https://reviweable.io, you can have both matching-commit diffs and whole-PR diffs, all in the same review.</plug>
piotrkaminski··on Making our new homepage fast and performant
Creator of Reviewable here. It's been a while since I used Critique, but if anyone in the know wants to tip us off on features we're missing that would make Reviewable a "five dollar" tool we'd love to add those in!
piotrkaminski··on How to Make Your Code Reviewer Fall in Love with You
Better tooling is definitely feasible, but confounding formatting and semantic changes also messes up blame for the affected lines and often makes a line's history misleading.
piotrkaminski··on Show HN: Etebase – An open source and end-to-end encrypted Firebase alternative
It might work, if you truly trust whoever signs up. The fundamental issue is that there's just one encryption key for the whole database, and you need to provide it to everyone who you want to have access to encrypted data. If you stop trusting someone for any reason your only recourse is re-encrypting the entire database, which is a painful offline operation. (You might also be able to support multiple encryption keys -- one per user, say -- but the library isn't really set up to make that convenient right now.)
piotrkaminski··on Make Your Back End Layer as Thin as Possible
I'm seeing a lot of criticism along the lines of "the trade-offs are not worth it in <context>" or "the article didn't address every detail". Well, yeah -- no advice is universal, and this blog post isn't a 500 page reference book. I think it would be more productive to help the author articulate the trade-offs and forces pushing for and against this architecture.

FWIW, Reviewable (https://reviewable.io) follows roughly this design and, after 6 years, it's still a fine system to develop in. It runs on top of Firebase RTDB which takes care of the security rules; if anything, I feel better having all the security rules articulated in one central location (the schema) rather than spread throughout the backend. Communication between client and backend also flows through the database (with very few exceptions), which lets the backend get away with an easy to scale queue-based design.

There are downsides, of course. As many posters alluded to, changing the schema gets tricky. It basically must remain backwards compatible for at least a few releases so as not to inconvenience the users, and some kinds of changes are just not feasible. And yeah, how the client wants to fetch data does affect the schema as well, though in practice I haven't found the impact to be too bad. Also, Reviewable has only one (browser) client, so I don't need to worry about duplicating logic -- I probably wouldn't pick this architecture if multiple clients were a requirement. Putting much of the business logic in a client-side model layer integrated with the database structure actually works out really nicely, though I still struggle with how to efficiently share some of the logic with server-side code.

Overall, I'm satisfied with how things worked out and would definitely consider using a similar architecture again in the right circumstances. The article is right on the money that if you're just getting started on your MVP it's worth thinking about a thin- or no-backend approach.

piotrkaminski··on Show HN: Etebase – An open source and end-to-end encrypted Firebase alternative
Since the pitch keeps referring to Firebase, I thought I might as well mention this here: a while ago I built an encryption layer for the Firebase RTDB at https://github.com/Reviewable/firecrypt. It's not nearly as nice as Etsebase appears to be, but if you're already committed (cough locked in cough) to Firebase then it will get you a good chunk of the way there. (And yes, I still actively use and maintain it.)
piotrkaminski··on Ask HN: Who is hiring? (November 2020)
Reviewable | Lead Software Engineer / CTO | REMOTE (US) | Full-time | https://reviewable.io

Reviewable is a bootstrapped code review tool that improves on GitHub PRs. I've been running the company mostly solo for 5+ years and need somebody to take over the core engineering, product management, and ops functions. You must be knowledgeable and excited about code reviews, and able to both plan a product strategy and execute on it. Ultimately, if you're interested and capable, there's a path towards assuming leadership of the business and partnership in the company.

Salary and benefits, US only (for now). Tech stack is Vue/JS, Node/TS, Firebase RTDB, GitHub API, and Docker.

Please get in touch with piotr@reviewable.io if interested in a chat. Thanks!

piotrkaminski··on Ask HN: Who is hiring? (October 2020)
Reviewable | CEO | REMOTE | Full time | https://reviewable.io

Reviewable: Reviewable is a peer code review tool for GitHub PRs that makes your workflow simultaneously more efficient and more thorough. Inspired by Google's Critique and launched 6 years ago, it has picked up a dedicated following solely through word of mouth and has made inroads into the enterprise market, particularly in the self-driving car vertical. While GitHub has started improving PR reviews again, they're aiming at an 80% solution leaving a lucrative niche in the other 20% for nimbler, more specialized companies like Reviewable.

Me: I built and have been running Reviewable since inception, mostly solo. I want to find someone to take over leadership of the company and inject new energy and purpose into it, while I get some headspace for new ventures. I'll remain available and involved but step back from the day-to-day decision-making loop.

You: You're passionate about code review and intimately familiar with GitHub. You're a strong engineer with a solid understanding of JavaScript (Vue 2, CSS, Firebase RTDB, Node), not afraid to take over a somewhat idiosyncratic 65+KLoC codebase, and with excellent written communication skills. You don't need anyone to tell you what to do and how to do it, and you're looking to stretch yourself into a leadership position without taking on all the risks of starting something from scratch.

If this sounds like it could be a good fit for you please get in touch with piotr@reviewable.io. Thanks!

piotrkaminski··on Teachers are ready to quit rather than put their lives at risk
I found an article that said there was exposure to a pre-symptomatic individual, but did they actually trace infection to that meeting?
piotrkaminski··on CDC director: Keeping schools closed greater health threat to children reopening
Why does it seem like everyone assumes you can only socialize in school? I don't think homeschooled kids are particularly deficient in this regard either.
piotrkaminski··on Twitter tags Trump tweet with fact-checking warning
According to Ars Technica [1], this page is "created and managed by our global curation team".

[1] https://arstechnica.com/tech-policy/2020/05/twitters-first-f...

piotrkaminski··on Ask HN: Who is hiring right now?
Reviewable | Senior Full Stack Engineer | REMOTE only | Full Time | https://reviewable.io

Reviewable is a code review tool for GitHub that improves on pull requests. It has seen strong adoption among companies that prioritize thorough but efficient code reviews. The company is bootstrapped and has been profitable for a number of years. I'm now looking for the first full-time hire: somebody who could quickly take the lead on all technical aspects (development [JavaScript, Vue, Node, Firebase RTDB, GitHub API], product, ops, contractor management) and eventually grow into the business role (support, marketing, sales, etc.). The position is fully remote and a great opportunity for a talented software engineer to assume control over a useful product with great growth potential, get their feet wet with a small bootstrapped business without taking on much risk, and learn new skills that may eventually help you start a business of your own! Please email piotr@reviewable.io to start a conversation if you're interested.

piotrkaminski··on Washington governor announces shutdown of restaurants, bars
Maybe not an ironclad promise, but the announcement does include this line:

"I know there will be significant economic impacts to all our communities and we are looking at steps to help address those challenges."

piotrkaminski··on The secret of academic success, or fun filled failure if you prefer
Heh, I took a couple classes from Bill back at UVic and, being young and full of myself, I occasionally pointed out mistakes in his teaching in front of all the other students. Luckily, unlike the faculty in his story, he never took personal offense. :)
piotrkaminski··on Ask HN: Starting Your Own LLC?
One tip that's not specific to LLCs but that I nearly missed: don't forget to check if the city you're based in has its own business licensing/taxing requirements. For example, in San Jose you need to pay $150/year for a "business license", even if you're just working from home by yourself.
piotrkaminski··on Facebook won’t let you opt out of its phone number ‘look up’ setting
> yet creating a new phone number for recruiting is not

Doesn't Google Voice solve this problem? Or perhaps there are restrictions I don't know about. Of course, you still have to remember to create a burner phone number before giving out your contact info...

piotrkaminski··on Swc – Fast JavaScript to JavaScript compiler
> It’s suprisingly difficiult to use use these tools just to bundle your code, but not transpile it down.

Isn't that what Rollup is for?

piotrkaminski··on CodeFlow: Improving the Code Review Process at Microsoft (2018)
It's hard to compare, since Reviewable is an OAuth app and hence needs an install per-user rather than per-org. However, on the page you linked I see a couple apps topping out at 6-7k installs, and most of the rest are in the low hundreds. This doesn't look particularly impressive to me...
piotrkaminski··on CodeFlow: Improving the Code Review Process at Microsoft (2018)
So answering myself, with numbers pulled from https://expandedramblings.com:

GitHub: 31M users

BitBucket: 6M users, 1M orgs

GitLab: 100K orgs

The GitLab number tallies with Emily's answer, which gives me some moderate confidence that these numbers are in the right neighborhood. I'm also going to assume that the users-vs-teams numbers are all in roughly the same proportion.

Based one these numbers it doesn't make much sense to target BitBucket unless either 1) they're growing much faster than GitHub (unlikely) or 2) their customers are a much better fit for Reviewable (possible, but it would have to be a truly significant difference in userbase composition). Targeting GitLab doesn't appear to make sense at all (as a business), though perhaps they're growing fast.

piotrkaminski··on CodeFlow: Improving the Code Review Process at Microsoft (2018)
Thanks, I'll take that criticism to heart. :) Can you expand on "childish style", though? My design philosophy is best summarized as "minimalistic but with touches of whimsy", but perhaps that comes across as childish?
piotrkaminski··on CodeFlow: Improving the Code Review Process at Microsoft (2018)
Thanks! Sounds like switching toolkits should address many of these issues.

And no, you can't shrink/hide code, other than by re-diffing. What can I say -- it's surprisingly hard to implement and didn't seem worth it.

piotrkaminski··on CodeFlow: Improving the Code Review Process at Microsoft (2018)
Eh, I don't think it's as bad as you make it sound. It's not "constantly", it's the first major migration effort for Reviewable. And honestly, I probably could've stayed with Angular 1.x for a few more years (it's still being developed, after all), I just got tired of working around its performance issues. There's also 4 years of learning how best to architect an application like this that led to the creation of a Firebase-centric model layer where Vue happened to be a good platform to build on. And even if we didn't switch platforms, a thorough refactoring would've been necessary after many years of accumulated technical debt.
piotrkaminski··on CodeFlow: Improving the Code Review Process at Microsoft (2018)
BTW, does anyone where to get better-than-anecdotal data on userbase size and composition for GitHub, BitBucket, and GitLab? And, ideally, growth trends?
piotrkaminski··on CodeFlow: Improving the Code Review Process at Microsoft (2018)
All fixed! (And it only affected people signing in from two different browsers at the same time, which was actually a pretty small proportion -- which is why it took so long to find and fix the issue.)
piotrkaminski··on CodeFlow: Improving the Code Review Process at Microsoft (2018)
Definitely something to think about then, since I think larger businesses are the sweet spot for Reviewable and that's where most of the growth has been coming from in the last couple years. Still, forking the codebase _really_ doesn't sound appealing...
piotrkaminski··on CodeFlow: Improving the Code Review Process at Microsoft (2018)
Sorry, not going to happen as things stand. A big part of Reviewable's attraction is the tight GitHub integration, so supporting other platforms (BitBucket, GitLab) would essentially require a fork or some pretty heavy-duty abstractions. Either way, future maintenance would become much harder, so I can't build a business case for it. Perhaps if BitBucket or GitLab were larger / growing faster, or if Reviewable was a much larger company with many developers to throw at the problem...
piotrkaminski··on CodeFlow: Improving the Code Review Process at Microsoft (2018)
I worked at Google ~2006-2012. Most of my experience was with Mondrian, but Critique was coming online shortly before I left. I used it long enough that the general "feeling" of using it stayed with me, but not long enough that I actually remembered specific features to copy -- especially since I didn't start even thinking about Reviewable until ~2014. So really it's more of a "spiritual ancestor". :)
piotrkaminski··on CodeFlow: Improving the Code Review Process at Microsoft (2018)
Thanks again, I might have to quote you on the home page. :) And yes, the UI is often the sticking point for adoption. I don't know if it's just the style / toolkit (an old version of Semantic UI) and switching to something like Material Design would take care of the problem, or if it's a deeper design / UX issue. A good onboarding flow would likely help as well but I haven't figure out what that should look like yet either. More feedback and advice is always appreciated -- and if you happen to be (or know) a UX expert who knows how to fix it I do have some budget I could throw that way. :)
piotrkaminski··on CodeFlow: Improving the Code Review Process at Microsoft (2018)
Reviewable author here -- thanks for the compliment! Redoing the UI is on the to-do list, once the migration from Angular to Vue is done.
piotrkaminski··on Destruction of evidence charges filed for remotely wiping iPhone
I'm kinda curious how the law would treat a dead man's switch that automatically wipes the phone if you haven't unlocked it for N hours (say, 24 or 48). (Assuming it was set up well before any event that prompted the phone's seizure, of course.) Could they somehow charge you for not warning the police about the auto-wipe when they took your phone? Does the answer change if you were officially under arrest and had a right to remain silent?

This seems like a pretty good idea in any case. If the seizing party can't crack the passcode anyway then it's a no-op. If they can then presumably they won't/can't do it right away, so it would add a bit of defense in depth.

← PreviousPage 4 of 9Next →