HNHacker News
TopNewBestAskShowJobs

piotrkaminski

731 karma · joined October 2, 2013

I run https://reviewable.io. You can reach me at piotr at ideanest dot com.
submissionscomments
piotrkaminski··on How ReadMe Went from SaaS to On-Premises in Less Than One Week
IIRC it's 10% of sales to begin with and goes down to 5% after some threshold. I'm sure marcc will correct me if I got it wrong.
piotrkaminski··on How ReadMe Went from SaaS to On-Premises in Less Than One Week
No, I actually meant "a single kind of server process that you just run more instances of to scale" but couldn't find a concise yet accurate way of expressing it. This differs from the setup described in the article since they have four different kinds of servers that need to be coordinated, interconnected, etc. -- a more complex setup that likely benefits from Replicated.
piotrkaminski··on How ReadMe Went from SaaS to On-Premises in Less Than One Week
I recently made an on-premises version of https://reviewable.io. I'd like to second most everything said in the article: use a flag, remove SaaS dependencies where possible, otherwise convert to use standardized services (SMTP) or apps that they can deploy internally as well (Sentry). It took me rather longer than a week but the ROI was still excellent.

One difference is that I decided to stick with a raw Docker container rather than going with Replicated (who are really nice people, don't get me wrong). In my case, everything runs on a single horizontally-scaled server so it's pretty easy to get running "manually". Also, all the potential customers I asked said that they were comfortable managing their own Docker environment, and some would actually prefer to get Docker images since they'd be easier for them to manage than "virtual appliance" VMs.

Another difference was that I use Firebase for the app's datastore and Google doesn't (and likely never will) offer an on-premises version. This was a show-stopper for nearly all customers, but it turned out that offering at-rest encryption of sensitive data with a key that never leaves their premises was sufficient to get through many of the security reviews. This obviously won't be acceptable to everyone but it can be useful to know that even if you have a fundamental dependency on an external third-party service there may be a way to keep using it in your "on-premises" product.

piotrkaminski··on Ask HN: Whatever became of the solo programmer?
I'm the sole developer on https://reviewable.io and there's no way I could've done that a decade ago. So yeah, I think you're right and the mainstream industry just hasn't caught up to the emerging reality yet. And as tooling and infrastructure keeps improving the effective power of a single developer will only continue to grow.

That said, greenyoda does bring up some good points: time, risk, and quality are very much issues with the solo approach. But I see these more as opportunities to be addressed via new products or services as the number of solo development businesses grows...

piotrkaminski··on DOJ challenges landmark Microsoft warrant case
Naturally. :) Hmm, I wonder if there's an actual addressable market niche here?
piotrkaminski··on DOJ challenges landmark Microsoft warrant case
I think even better would be to stripe all data across a bunch of regions.
piotrkaminski··on The Dutch Reach: Clever Workaround to Keep Cyclists from Getting “Doored”
I expect that cities will heavily subsidize it, to bring it down to about the level of public transport (but far more convenient). I'll admit it's just guessing at a very nebulous future, though.
piotrkaminski··on The Dutch Reach: Clever Workaround to Keep Cyclists from Getting “Doored”
> They'll still be opening doors and riding bikes however.

Will they? I'd expect an autonomous car's doors to be under its control unless the passenger declares an emergency (which would be a Big Deal, call the police, etc.). Also, once autonomous cars are plentiful and transportation is dirt cheap, how many people will still be riding bikes in congested areas?

piotrkaminski··on Too Many Tools and Frameworks (2015)
On the contrary: when looking for a global maximum you will almost certainly have to pass through local minima, so different _is_ good in this case.
piotrkaminski··on Why kernel development still uses email
Amusingly, the article references Kubernetes and its growing pains a couple times, but fails to mention that it adopted Reviewable (on top of GitHub) for doing more complicated code reviews. I don't know if Reviewable would scale to kernel development -- and it certainly doesn't support offline work, etc. -- but at least Kubernetes seems to be doing all right with it.

(Disclosure: I'm the founder of Reviewable.)

piotrkaminski··on Show HN: Poetically simple code review on GitHub
I'm also curious what the issue is. While I understand that a full open source license would be preferable to many, if the choice is between Fair Source and a proprietary code base, is there a rational reason for users to prefer the latter? (Assuming, of course, that the licensor doesn't try to spin the Fair Source as open source in PR, which would be annoying. I assume Sourcegraph doesn't do this, though.)
piotrkaminski··on Show HN: Poetically simple code review on GitHub
I wholeheartedly agree, but clearly other people have different thoughts or priorities. :)
piotrkaminski··on Show HN: Poetically simple code review on GitHub
AFAICT this stems from a different philosophy of what a code review should be for. GitHub appears to believe that code reviews should be very high-level, with most discussion focused on overall design issues and only the latest version of the code, rather than detailed line-by-line reviews of incremental changes. This attitude is shared by at least some number of GitHub users, since many people who visit https://reviewable.io (my attempt at a code review tool in the vein of Phab or Gerrit) don't even get why it might be needed. So perhaps GitHub is not entirely wrong... but it certainly opens up a nice niche for providing tools to those who like more thorough reviews.
piotrkaminski··on Crashing, Burning Planes Don’t Stop Passengers from Grabbing Their Luggage
Right, so I wonder how we could change the incentives so their optimization function is a little more socially responsible? Perhaps a law that allows civil lawsuits for false positive alarms would help, but I'd be afraid of unexpected side-effects.
piotrkaminski··on Crashing, Burning Planes Don’t Stop Passengers from Grabbing Their Luggage
> Meanwhile the makers of the alarms have an incentive to be overly sensitive because a false positive is much less dangerous than a false negative.

I wonder whether this is actually statistically true, if false positives cause true positives to be ignored by some non-trivial proportion of the population? I think it's just as likely this is legal CYA from the alarm makers -- they can only get sued for false negatives, after all.

piotrkaminski··on How to escape lock-in with a multi-cloud stack
Yeah, I agree that open sourcing Firebase is too much to ask. But there's other things they could be doing: a) document the wire protocol and license the clients for free use with any server, b) make the API definitions public domain and provide a compatibility test suite for alternative implementations, c) lead a standardization effort on real-time JSON databases, etc...
piotrkaminski··on How to escape lock-in with a multi-cloud stack
Actually, the article specifically talked about some non-portable services and explained why this wasn't a big deal, so to me leaving out Firebase implies that 1) it is a big deal and 2) they're not interested in making Firebase apps portable. My conclusion is that they're only opening up the services where they're not in the lead and getting people locked into the ones that are. Which is fine and a great business strategy but rather detracts from the "we're all about openness and choice" image they're trying to project.
piotrkaminski··on How to escape lock-in with a multi-cloud stack
To be fair, I think Horizon is one of the more promising Firebase alternatives. However, it has completely different semantics, and is quite immature at this point (look at the limitations: http://horizon.io/docs/limitations/). But if Firebase remains proprietary and Horizon continues to improve I could certainly imagine that rewriting my app will eventually start to look attractive.
piotrkaminski··on How to escape lock-in with a multi-cloud stack
And then rewrite your entire app against a new API. No thanks.
piotrkaminski··on How to escape lock-in with a multi-cloud stack
After all the noise about Firebase at the last Google I/O, it's odd that the article doesn't mention it at all. I guess its proprietary API and undocumented wire protocol with no open source alternatives would be off message...
piotrkaminski··on Nexus phones now identify suspected spam callers
Presumably because he wants to be able to dial out for emergencies, and to call people who don't use instant messaging or email (e.g., local businesses, or <shudder> taxi dispatch).

Plus there's the fact that many official forms require a phone number of some sort, and it seems less evil to provide a number you own but don't answer than a random one.

piotrkaminski··on LGTM is a simple pull request approval system for GitHub
And of relevance to the original article, in Reviewable you can customize your review completion condition with a snippet of code it will run on your behalf and post the result as a GitHub commit status, so you can have basically any approval system you want. One of the examples is a simple LGTM-based system like in OP.

(Disclaimer: I run reviewable.io.)

piotrkaminski··on A Taste of JavaScript's New Parallel Primitives
If the problem that this is trying to solve is that `postMessage` is slow and you can't transfer slices of arrays, then perhaps they should solve it by speeding up `postMessage` and making array slicing cheap? Forcing a shared-memory concurrency model into JavaScript seems like a bit of an overreaction.
piotrkaminski··on Abandoning Gitflow and GitHub in favour of Gerrit
Phabricator is nice, but it's more of a full-featured replacement for GitHub as a whole. Some people want to keep most of GitHub and just improve on the code review aspects.

> By the way: I live in Europe and I haven't worked for one single company which would allow their developers to host proprietary source code with a third party SaaS provider.

Fair enough, companies vary widely in their acceptance of SaaS -- though Reviewable has plenty of European customers too. But to clarify, neither Review Ninja nor Reviewable (not sure about Omniref) actually host code themselves: they just access it through GitHub APIs without storing it. You can also deploy Review Ninja (and soon Reviewable) on-premises, though of course that means you're on the hook for administrating the system again.

piotrkaminski··on Abandoning Gitflow and GitHub in favour of Gerrit
Try https://reviewable.io then. Just code review, runs on top of GitHub, no extra repos to manage. (Disclosure: I'm the founder.)
piotrkaminski··on Abandoning Gitflow and GitHub in favour of Gerrit
Sorry about the mess on the demo review -- since everybody gets write access to try things out, it tends to get messy over time. I just reset it now so it looks clean again, and should probably just stick the reset script in a cron job...

It's really odd that you got a nil default diff range. I can't reproduce it with either anonymous or authenticated access. If you can, could you please open an issue with more details so I can debug? Thanks!

piotrkaminski··on Abandoning Gitflow and GitHub in favour of Gerrit
The article isn't particularly well written or argued, but it does have a core of truth to it: serious code review in GitHub is painful. However jumping straight to Gerrit to solve that problem seems like overkill to me. Sure, you get a really powerful and extremely configurable code review system, but you have to retrain for a new (and honestly a little long in the tooth) UX and spend time administrating the system.

A lighter-weight SaaS like https://review.ninja, https://omniref.com, or https://reviewable.io (disclosure: this one's mine) might be a more appropriate solution. Specifically to the article's points, Reviewable has a nice reviews dashboard and will show inter-commit diffs within a PR (whether you're rebasing/amending or not), hiding any files with no changes since you last looked. Its default review completion criterion is that all files have been marked as reviewed by at least one person and there are no unresolved discussions still going on, but you can customize this to your team by writing a snippet of code to run against the review's state, e.g. to implement LGTM approval or even a voting system. Reviewable will also update a status check on the PR so you can enforce review completion before merging if that works best for your situation.

Best of all, because both systems integrate tightly with GitHub, there's no need to learn a new workflow or mess around with new git commands. Gerrit still has its place but I don't think it should be the tool of first resort.

(Edit: added mention of Omniref.)

piotrkaminski··on Abandoning Gitflow and GitHub in favour of Gerrit
You might want to check out https://reviewable.io. It has most (if not all) of the goodness of Gerrit, but is trivial to set up (SaaS) and integrates smoothly with GitHub. Every PR becomes a review and gets automatically updated whenever you push to the branch.

Disclosure: I'm the founder.

piotrkaminski··on Ask HN: How do you review code?
I should do a better job of tracking "interesting" reviews, but for now the easiest way to find some is to poke around the PRs of some open source projects that have adopted Reviewable, for example https://github.com/servo/servo/pulls, https://github.com/cockroachdb/cockroach/pulls, and https://github.com/dolphin-emu/dolphin/pulls. Each PR will have a link to the corresponding review in its description.

Let me know if you need anything else!

piotrkaminski··on Ask HN: How do you review code?
If you're willing to use GitHub, then https://reviewable.io has all the features listed above and more.

Disclosure: I'm the founder.

← PreviousPage 7 of 9Next →