HNHacker News
TopNewBestAskShowJobs

technoweenie

1,562 karma · joined July 20, 2008

\m/
submissionscomments
technoweenie··on Say hello to Octicons
They're for GitHub use only.
technoweenie··on Django is now (officially) on GitHub
We have an early alpha program if you want to import your tickets to GitHub. We helped move Parrot (and a few others) over. Contact support@github.com.
technoweenie··on Rails 4 will establish a new background job queueing API
GitHub doesn't actually use Resque directly (well, except some rare cases). defunkt built RockQueue to be our internal queue interface while he migrate the app from DelayedJob to Resque. This looks like the same concept.
technoweenie··on An easier way to create GitHub repositories
You can sort by Submitted/Updated/Comments. Feel free to send feedback to support@github.com if this isn't what you're thinking of.
technoweenie··on An easier way to create GitHub repositories
And we're working on /so/ much more than new repo screens too :)
technoweenie··on Of GitHub and Pull Requests (and comics)
This is closer to how we work at internally at GitHub. Everyone files pull requests for non trivial changes, and are responsible for merging and deploying them safely. Edit: This works because we all have push access of course.

This changes when you consider open source projects. Any change that is simple enough that I can scan and give my thumbs up, is likely one I can scan and click the merge button. Immediate Travis-CI results tell me everything is happy.

Anything where the merge button isn't sufficient is probably not something I'd like a stranger to push to my repository. If they're not a stranger, I'd seriously think about sharing collaboration access.

But hey, we're not necessarily done with Pull Requests. I have various ideas like this I'd like to explore at some point.

technoweenie··on Of GitHub and Pull Requests (and comics)
That's definitely a change I'd bring up with the project first. I agree that having compiled code in there is bad, but it's typically not something a first time pull requester touches. Same goes for project files (Gemfiles, package.json, licenses, changelogs, whatever).
technoweenie··on Zmqc: netcat for ØMQ
ZMQ is specifically content agnostic. It looks like zmqc is too. As zacharyvoase pointed out, you'd just pipe the output of messages to other tools that can handle JSON/MsgPack/Protobufs/whatever.
technoweenie··on Why I’d like a “license type” setting for GitHub projects
GitHub detects the presence of README files by file name. It'd be pretty easy to do that for LICENSE files too of course. Look for LICENSE, MIT-LICENSE, etc.

The trick is actually identifying what type of license it is.

Pop quiz: What license is this?

https://github.com/sinatra/sinatra/blob/master/LICENSE

This problem would be perfect for a tiny ruby script like Linguist: https://github.com/github/linguist. Just something simple that's given some filenames and contents that can return the license type.

It'd also be nice to handle non software licenses, such as creative commons. I'm not sure what the convention is for specifying that in Git repositories, however.

technoweenie··on The Future of Python HTTP
I hacked up a Faraday (my ruby HTTP client) plugin that uses ZeroMQ: https://github.com/technoweenie/faraday-zeromq. I honestly don't know if it's worth it though. It's easy enough to write your own ZeroMQ stuff.

Example: https://github.com/dotcloud/zerorpc-python

technoweenie··on #1 CSRF Is A Vulnerability In All Browsers
Another clarification: He wasn't making noises for a long time with _GitHub_ and being ignored. His support responses were replied to nearly immediately (except where the timezone differences came into play). We take security reports very seriously.

We'd have preferred a more responsible disclosure, and I hope he (and others) are more careful about this in the future. Most reporters we get act very responsible, and we are always gracious (and even contract work from them in some cases) In his case, we saw activity that he didn't report to us, and suspended his account while we did a deeper investigation.

The Rails community and we still think that his proposed solution is not a good idea, but it did provoke exploration in some other ideas.

https://github.com/rails/rails/issues/5228

http://techno-weenie.net/2012/3/19/ending-the-mass-assignmen...

http://weblog.rubyonrails.org/2012/3/21/strong-parameters/

technoweenie··on Crossroads I/O is a fork of the ZeroMQ project
For anyone that still cares, this has been tweaked. If you attempt to merge a pull request that has changed since you loaded the page, it'll require you to re-review the pull request.
technoweenie··on Crossroads I/O is a fork of the ZeroMQ project
GitHub pull requests are tracked by a base and a head commit. Usually, base is master, and head is some feature branch. This allows the pull request on GitHub to pull in new changes to the commit as a discussion forms around it.

So in that sense, he is correct. There's no way to ensure that clicking the merge button is indeed merging what I think it's merging. Now that I type that, we could easily just include the latest SHA in the form and check that. Problem solved!

Alternatives to this are:

* Merge manually from the command line. This is typically what we do at GitHub. * Request that people file pull requests with a SHA as the pull request head. This makes it impossible to update the pull request with future commits. * Don't use pull requests.

technoweenie··on SSH Key Audit on Github (required)
We sent someone back in time to make this change. Somewhere there's an alternate universe with a secure GitHub by default. Thanks!
technoweenie··on SSH Key Audit on Github (required)
This isn't the only thing we're doing. Most of the work is going on behind the scenes though.
technoweenie··on SSH Key Audit on Github (required)
We have stats on this from other sources, actually. But it did provide some interesting graphs this morning :)
technoweenie··on SSH Key Audit on Github (required)
There's no way to delete keys on another account. The bug only let someone move their key to another account.
technoweenie··on SSH Key Audit on Github (required)
It was a mass assignment vulnerability in our code.
technoweenie··on How Homakov hacked GitHub & the line of code that could have prevented it
Git has no real way to track that, only commits. We do track it internally, but AFAIK it's not exposed except through post-receive hooks.
technoweenie··on How Homakov hacked GitHub & the line of code that could have prevented it
It was a temporary suspension while we investigated the scope of the damage. There was some other weird activity on his account that he wasn't up front about.
technoweenie··on GitHub and Rails: You have let us all down.
We didn't have the luxury of time. We were going back and forth with him over the weekend, and he pushed the commit 2 days after the original report. I admit, I was having some issues understanding his vague reports and went down a different rabbit hole early Sunday morning.

I definitely wanted to do a more careful audit and investigation, but my hands were tied.

technoweenie··on Public Key Security Vulnerability and Mitigation
He wasn't upfront about everything what he was doing, so we had to investigate.
technoweenie··on GitHub and Rails: You have let us all down.
It's a fake.
technoweenie··on Responsible Disclosure Policy
We use this (posted by @dhh) https://gist.github.com/1975644 in some spots, or simply just Hash#slice. We have some other thoughts on making params access more explicit. The problem with explicit patterns is they can get left out if a developer forgets.
technoweenie··on Responsible Disclosure Policy
This is true. We actually don't use mass assignment that often. He happened to catch 2 our of 3 spots that still used it. Everywhere else is explicit about what to accept.
technoweenie··on Responsible Disclosure Policy
Yup.
technoweenie··on Responsible Disclosure Policy
We saw some weird stuff on the account that he wasn't upfront about. Though, our first priority was clearing the bug up.
technoweenie··on GitHub and Rails: You have let us all down.
We suspended it after fixing the bug to make sure he didn't retain access to something he shouldn't. We rarely do this, but he wasn't upfront with everything he was doing on the site like people that disclose vulnerabilities responsibly.
technoweenie··on Hacked: commit to rails master on GitHub
https://github.com/blog/1068-public-key-security-vulnerabili...
technoweenie··on Ruby Patterns from GitHub's Codebase
We use Unicorn, which provides a Rack handler for Rails 2.2 apps. I just mounted the an API router app before the Rails handler in our config.ru. The API router app is just a big regex that looks for API related urls, or passes through to Rails. Though, jnunemaker recently showed me a trick where you can mount Sinatra apps in other Sinatra apps through `#use` (like any Middleware). I may try that out and get away from my ghetto regex routes.

We recently upgraded to Rails 2.3 which is built on Rack. `ActionController::Dispatcher.new` is the last Rack app on the stack now.

← PreviousPage 4 of 9Next →