Hacker News Reader

Comment by pratu16x7 | Hacker News Reader

Supported across all major browsers :) We've covered much ground on the most used charts (while the heatmap just happened to be something we needed) and have the basic components down. That'll facilitate putting in, say, more axis charts in future. We're sure of not running out of ideas, there are just so many chart types out there :D

View on HN

> Supported across all major browsers

Please be more specific: Frappe Charts doesn't work in MSIE 11 which is the latest IE for Windows 7 which is used by a lot of enterprises.

It works on iOS, and I think there are a lot more iPhones out there than win7 desktops. ;)

Be that as it may, that doesn’t address the apparent fact that it doesn’t work in all major browsers — certainly IE11 would be considered one by most.

Moreover, whatever % of global browser share IE11 has, within the market of people who want charts, it's much higher. The simple chart is also the #1 feature priority of every business-IT product manager that has ever existed, narrowly beating "make it work in Internet Explorer".

Google Charts is a solid lib if you need the go-wide support

Do you have a separate repo with unit tests? If not, how do you test the charts?

We look forward to adding those (just created an issue). They are quite decoupled as of now, so shouldn't be much trouble.

https://rbcs-us.com/documents/Why-Most-Unit-Testing-is-Waste...

I have really bad experience using controls that didn't have a large test suite. They don't have to be "unit" , I just care about the ratio of the number of state transitions it tests to possible state transitions. If that library was written in typescript (or some other strongly typed language), I'd been slightly less worried about the lack of tests, and possibly slightly more convinced to try it out in its early stage.

I agree, unit tests wouldn't be very useful here, i was thing that visual regression tests with constant data, that capture graph image and compare with older version for regressions would have been really nice here.

As a side note: I find these kind of tests flaky, because the antialiasing doesn't seem stable at constant resolution on the same machine & browsers when you repeat tests. When you do a fuzzy compare (ie. allow for X pixels difference), then you are always chasing the golden middle. A test I would like to see for a control is trigger multiple state transitions (for example change 5 properties of a chart), do assertions on the generated DOM.

Unless maybe some HNer knows how to do such SVG/picture testing non flaky?

If you also support react native using their canvas, it might be a pretty sweet addition. Plotting libraries are somewhat missing in react-native.

Reply on news.ycombinator.com