I think I s unarguably true that having our data online and backed up is a risk that needs to be weighed up against the very real advantages we get. That applies to both Apple and Facebook. However only one of those companies has explicitly built a business model around selling that data. Let’s not set up any false moral equivalencies.
By itself having data we have chosen to entrust to them isn’t a problem. It’s what they choose to do with it that matters, alongside the gathering of information we have chosen not to entrust to them regardless of our choice.