Vertical farms are kind of a crock, kind of. The idea of indoor agriculture is not, however (just look at Thanet Earth), and there is an advantage of building up a few floors and using grow lights to supplement the loss of passive lighting.
A series of low-rise warehouses using hydroponics in the outer rings of a city makes a lot of sense.
However, the architectural games people are playing with huge spires in the center of Manhattan, those are ridiculous, and always have been.