Hacker News Reader

Comment by sefrost | Hacker News Reader

https://apply.army.mod.uk/login

Is this the website?

The HTML is full of comments like:

  <!-- This was a temporary Single Sign on fix - I think it's no longer needed?  SVL -->

  
  <!-- This is being done since bundling is currently breaking css files!!!-->

I'm not calling out the developers, I'm sure they didn't get £113m, but where did it go?

View on HN

The two comments you've quoted are literally the only comments that indicate hacks or broken things in the entire HTML source of the linked page. There are other comments, but they are innocuous descriptive comments and not indications of problems - things like:

    <!-- Adobe Analytics script (2 of 2) -->

Saying it is "full of" comments "like" the ones you've quoted is just plain not true.

The assets have many lines of commented out code and comments like the ones I mentioned:

https://apply.army.mod.uk/Content/Scripts/custom/RoleFinder....

I'm not calling out the developers, but I would suggest many people here would not allow chunks of commented out code in the projects they work on. It suggests poor use of source control, meaning the site won't be maintainable and will have to be replaced. Of course it's likely this is because of conditions placed on the developers by their managers, those are the people I'm taking issue with here.

I'm just miffed off that as a UK taxpayer we're on the hook for this. Again. If I'd paid for this site personally I'd be upset.

Eep. I agree that that's a bad look.

I also like the way that in one event handler in that file they check for the existence of stopImmediatePropagation before calling it and if it's not there they fall back `cancelBubble = true` to support old IE versions, but that in another spot they happily call stopImmediatePropagation() without any check. I'm not certain, but that certainly looks wrong; it seems like they'd've been better served by a polyfill.

Imagine you need to create a website with every minor technical details perfectly matches the client's requirement. The client has no technical knowledge at all but he insist to be in charge on everything.

add to that a commercial model that thrives on confusion, and a race to the bottom in terms of cost and see where you end up!

"Full of" ? what a lie

Reply on news.ycombinator.com