I see a parallel to Thinkpads in that I can imagine that Sonys have a little more appeal to some more technical crowds than e.g. Samsungs. And probably Sonys have less appeal than Samsungs for the average Smartphone user.
Sony phones do not have all the newest fancy features, but I found the flagships to be reasonably powerful and just work™.
I never liked Samsungs because they modify the default Android experience too much and ship too much crapware. Since ~Android 6 they are more aligned UI-wise, but the "back" button on the right, and the different middle button are also annoying. Last but not least, being an Android dev, Samsung is one of the most annoying vendors, which makes weird modifications to their fork of Android, which result in Samsung-only crashes.
(Having said that, for majority of consumers, none of this is an issue, given the sales numbers.)
In any case Android Q disables access to external storage, so it's either one submits to Apple-style walled garden or seeks something else. Where those vendorcrap apps aren't there or are removed without any problem.
And if someone does submit to the Q changes, then there's no point to discuss.
There are also rugged devices like the Zebra TC75, but even though it has a 4.7" screen, the phone itself is large. Similarly, the Blackberry KEY2 has a 4.5" screen, but the keyboard adds quite a bit of bulk. Both phones are also pretty wide, which is a big factor in whether it fits in one hand.
The Galaxy S10e is being touted as a brilliant compact phone, but it's the same size as an S7, and comes with a giant 5.8" screen. Today's "compact" phone is yesterday's "phablet".
Then there are the clamshell smartphones. Surely there's a market for these. The only one sold in the US is the ZTE Cymbal-T, and it's carrier-locked.
And while I'm ranting -- why hasn't anyone made a decent shoephone yet?
In the bigger picture, I think that Sony never really managed to emancipate itself from the network provider sales channel. According to hearsay, the whole "new models twice a year, and a premium variant on top" madness was entirely driven by Japanese network providers. A network driven product portfolio has never worked out well for a phone brand, because the resulting multitude of models makes no sense to off-channel buyers. Which includes every international buyer outside the market reach of the "home" networks of the network-driven models. Motorola used to suffer from this as well.
What does it gain for all that? Screen resolution, mainly, going from 319 PPI to 483. I'd be hard pressed to care less about that change, as I'd need a VR headset or other magnification to notice.
Hopefully the next time I need a new phone someone will make a compact device with a folding screen.
And I'm still salty over the fact that the Pie update for the XZ1 Compact still doesn't have Night Light (Also no gesture navigation)