I wouldn't try to analyse it. A smart Japanese guy took them for a ride, he took a cut, and then handed it to some software developers in Silicon Valley who saved some and then spent the rest. That is it. No value created. No investments. Just redistribution away from stupid people.
Btw, this happened in the 1970s too. When the oil price spiked, the Saudis didn't know what to do with their cash so they just deposited it in US banks. The US banks didn't know what to do either so they started lending to South America. They knew what to do: politicians either stole it or handed it out as bribes to their supporters. The result was Citibank and a few other banks going insolvent in the early 80s, and a massive debt crisis in LatAm from 1980-1993(ish).
...the Saudis also gave a bit to Britain, who had their own debt crisis (also because of cash handouts to political supporters) and devalued a good chunk of their money away.
They will lose money always.
The only market with infinite liquidity is US Treasuries (that is where the Chinese put their $3trn of foreign currency reserves). Mortgage-backed were liquid until GFC, and liquidity in corporates is falling because dealers can't carry inventory (afaik, not expert...MBS pre-GFC was ultra liquid for sure though and seen as an alternative to USTs).
The Saudis own $150bn here (and growing because of Trump/MBS relationship apparently) but I think the issue the Saudis have is that they have a fucking huge budget deficit. There are tons of people on do-nothing, civil servant jobs (mainly royal family members), they have to spend a ton on defence (ostensibly against external threat but the royal family is terrified of an uprising too), and they spend a ton on welfare to buy popularity.
They are definitely investing for a return.