Macbook Air > Macbook Pro just because of the keyboard
I agree with the general consensus here however — Apple needs to get its shit together and stop pursuing meaningless marketing metrics and start making great computers again.
SWEs / tech people (myself included) probably overestimate their importance vis-a-vis Apple, but it would really only take one great alternative from Razer or Lenovo or a new company to cause a mass exodus. That will definitely not be good for Apple.
At this point I use Apple because they piss me off slightly less than the alternatives let me down aesthetically. It’s hubris for Apple to assume that will always be the case.