As far as "illegal" goes, yes numbers games were and are illegal. Nobody cared because the cops got paid off. It's a big part of what made NY what it is. It was so successful that most every state now has a lottery system. The odds of winning in state lotteries are, well, you already know what they are. State lotteries are total rip off designed to fleece the public. State lotteries exist because the pols realized they could make bazillions of dollars running numbers on a large scale and they could chase the competition away, too. So, in a sense, numbers games became legal, but controlled by the usual suspects.