I wanted to ask, did the company you were interviewing for tell you what they wanted to get out of the assignment on their end - specifically what they were assessing you on?
I wanted to ask, did the company you were interviewing for tell you what they wanted to get out of the assignment on their end - specifically what they were assessing you on?
1) App performance. We will be looking at the wait times for reader to see the content — the shorter, the better.
2) We will evaluate your code’s quality. Does your code have good modular design and testability? Is it easy to read?
3) We prefer the project to be lightweight, and all dependencies should be well justified.
I was focusing on #1 and #3. As for #2, they found it too tightly coupled and hard to read.
I thought that the app is simple enough to not warrant extracting modules in the main app logic. The coupling was also there for performance / filesize reasons.
These sorts of interactions sound pretty far out now, but a few years ago who would have thought that people would be typing code into a web page in real time as part of a job interview process?
Sadly, I didn't get a chance to provide feedback to the criticisms. At least not in an impactful way — the decision has been made.
That's a shame. It sounds like the criteria were fairly well defined, but it would be nice if your assignment was used as a starting point for good in person discussion. E.g. "we think the code in index.js was too coupled - what could we do to break that out?"
This was the only time I've experienced that.
It's an arbitrary construct that is not indicative of what form the work will take. Only the first three months of working with someone will give any real indication of what'll be like to work with them for another three+ years.
Agreed.
I had a similar code challenge and after joining the company, in the first year of work I did little if any JS work which even approached the level of the challenge I was presented with. To this day, I'm still bitter the company gave me the old "bait and switch" tactic to get me to come work there.
Adding complexity for performance will be a pure negative unless you can factor that out so the next person can use it on their component.
I would read this code and think I was dealing with a very talented programmer that needs seasoning. Such a programmer can be very dangerous to the wrong company, as the seasoning will have to be added on the company’s dime.