I could see them being useful for keyboard designs with very few keys, like https://olkb.com/collections/planck.
If you have deeply-nested layers, having some way to identify what state your keyboard is in can be helpful. Having screens instead of LEDs is definitely an expensive luxury, though.