Back when I was still in a project that did code reviews, it really helped for me.
Similarly / a tip: `git add -p`, to view and review your changes one at a time. You can split up changes into separate commits as well using that technique.
Back when I was still in a project that did code reviews, it really helped for me.
Similarly / a tip: `git add -p`, to view and review your changes one at a time. You can split up changes into separate commits as well using that technique.
I spot things in `git add -p` that I had missed when writing the code in my IDE.
Then I spot more things in the github "Create PR" page that I missed in the previous step.
Then sometimes I spot more things in the created PR that I missed in the steps above.
Always skim back over your PRs, especially in the final context that they'll be reviewed in. Something about it puts you into "reviewer" mode and you'll get a better PR out of it.
> Hard agree.
Edit: Damn, I misunderstood both the GP and you. My apologies.