The trip from Toronto to Montreal is a full day and is worth it if you hate flying and want to avoid security. However as it gets used more and more they are adding more airport style security features taking away that benefit as well.
Now, when I travelled to Japan and rode the shinkansen I really enjoyed it and was amazed by how quickly I could get around. But I also saw how absurdly expensive it was and how without government support on top it fundamentally would be impossible except in the highest density corridors of Canada and the US.
I love trains. Absolutely adore them. But I cannot see how in the low density areas of North America they can remotely compete with cars or airlines.