IMO travel insurance sometimes makes sense. Circumstances like high altitude trekking that may require expensive evacuation. Expensive non-refundable trips, especially those that a broken ankle before or during the trip could put a rapid stop to.
That said, I've only purchased travel insurance maybe a half-dozen times out of probably hundreds of trips.