I'm certainly not trying to nay-say it, and continued research is worthwhile. The history has been that when a new thing is announced that will beat silicon, by the time that thing comes to fruition, silicon has caught up through just grinding incremental improvement.
Optics can solve some interconnection issues, since it isn't confined to 2-dimensional (or "2-1/2" dimensional) structures.
Silicon transmits IR, and can be used for optics and waveguides. So there's two sides to silicon, with the transition in that regime of about 900 nm.
Actually, silicon photodiodes work down to about 1050 or even 1100 nm, but at a rapid loss of sensitivity and temperature stability. On the UV end, the silicon might be perfectly friendly, but the layers of stuff on top of the silicon become problematic. Silicon is also used for higher energy particles, just due to the havoc caused by absorbing an X or Gamma ray.
For scalability, the larger the die size the more it costs. The yield also becomes a problem as the die area increases due to random defects. I’d don’t understand the visible light comment since silicon absorbs below 900nm (visible and NIR).
When I was in grad school, the nuclear physics lab had racks of cables of different lengths that were conveniently labeled in nanoseconds.
In all likelihood, we will find many more usages for optical processors, but I really don't think they will ever be your main CPU.