Analog computers seem to be very well fit for running neural networks (that's since the beginning, this is not the fist time normal computers are beaten), but they are a really bad choice for mostly everything else.
In all likelihood, we will find many more usages for optical processors, but I really don't think they will ever be your main CPU.