Hacker News Reader

Comment by dhritzkiv | Hacker News Reader

Yes! Gitlab's offerings are great, and our team doesn't even scratch the surface of what's possible with its feature set.

That said, MRs with over 1000 lines of changes are painful sometimes impossible to review. Even small MRs feel clunky, due to how many panels there are (yes, I know they're collapsible). Because MRs are one of our most used features, it sometimes makes me consider switching to GitHub for their much nicer PR UX/UI.

View on HN

I prefer to use Intellij now for reviews. How can people review any kind of code in that PR web UI ? I mean I used to do it but not anymore

yeah there seems like there is some web -> idea connection that should exist for super slick in-IDE reviews. Best reviews means most context, IDE has the most context about the code (is why its best to resolve merge conflicts too) so we should be leveraging it more.

Always surprised to see people resolving merge conflicts anywhere other than their IDE, IDE has the most knowledge about the inputs to the merge and your chosen resolution, why would you ignore that important info? (like.. does the resulting file compile? for ex..)

Do you review code in the code editor, the git diff, or some specialized full-PR/MR diff with integration with online comments and discussions?

https://stackoverflow.com/questions/40217494/how-to-review-a... says IntelliJ has GitHub-only specialized PR review/commenting.

Would be very curious about your thoughts on Reviewpad (https://reviewpad.com). The interactions you have on the IDE are very different than a tool that was specifically made for code reviews.

I really enjoy the idea. Seems like a good tool to use. do you plan to release an arm64 docker version soon?

Yeah, I should really quit struggling with Gitlab's.

For really large MRs, I use Tower + Kaleidoscope to view the changes. But then I can't easily leave a comment on a line of code (a big part of the review process)

Reply on news.ycombinator.com