Using analog brightness control is nice because there is no flicker, and there is no stepping. But, with common potentiometers there is only a very narrow operating band due to how nonlinear the LEDS are, and it tends to be pretty touchy due to construction of the pot.
I would love to figure out how to make an arbitrary transfer function shape using a pot as input, and some combination of transistors/op-amps to keep the nice analog behavior.