Hacker News Reader

Comment by istjohn | Hacker News Reader

As a mostly self-taught dev, it's really helpful to read code reviews like this. I also enjoyed the author's code review reference[1]. That document cites Erick Breck's code review reference as inspiration. Is that publicly available? I couldn't find it on his website or via Google.

Does anyone know where one can find high quality public code reviews? I imagine there must be open source projects on GitHub with good public feedback on pull requests. Any ideas of specific projects to look at?

Finally, I haven't found much information on database migration best practices. Any good articles, books, or other resources people would recommend?

1. https://www.natemeyvis.com/code-review-reference/

View on HN

Unfortunately, that was the biggest problem with Anki’s DB. It was done by feel by a self-taught dev.

And now he has spent years trying to slowly undo the stuff he baked into it at the lowest levels.

It's fine to do stuff independently without knowing, but please seek feedback and advice on crucial design decisions.

> but please seek feedback and advice on crucial design decisions.

Or at least isolate them from the rest of the code. Of course, it's difficult to recognize which design decisions are crucial without already being an expert, so this sort of advice is probably silly. It's probably also the kind of advice that would have been more likely to strangle Anki in its crib rather than giving us the opportunity to discuss how a wildly successful program that has helped many people learn many things should improve its data model.

Yeah, it's a hard thing to judge and balance.

I'm not saying they need an expert or they shouldn't push forward anyway, but it's good to recognize when you're out of your depth and to get input when possible. There's a lot of value from just running something by someone else to see if they can understand it and if something occurs to them that would make things simpler.

[Author here.]

Thanks for the note! Unfortunately Eric's reference is not publicly available (as far as I know).

I'd love for more people to collect and publicize sets of commonly used code review notes.

Others here will know much more than I do about which publicly viewable projects have the best (public) feedback. Good luck!

Reply on news.ycombinator.com