I am really curious but do not have the time to check this myself: is the vscode telemetry part of the open core bit? The reason I ask this is because I agree with your points and I usually allow telemetry for FOSS programs (for example [1]).
If the telemetry code is open and people can verify that there isn't any identifiable data that is being collected, I don't see any issue with leaving it on in vscode too.
[1] https://blog.davidedmundson.co.uk/blog/what-we-can-learn-fro...