That's the same reason people use them on numbers too.
It may add value, so may be figuratively a very positive change. But not literally.
if your boss looks at a red diff and thinks it's bad, that's a you and him problem, while the primary purpose for color syntax continues to be making it easier to parse for people who know what they're looking at
A red apple is not inherently bad nor is a green apple inherently good. A person might enjoy one versus the other to eat, but if you just ask someone to identify attributes of an apple, the color likely won't prompt statements about the good/bad nature of the apple, and instead would decide the apple's use based on your needs. This can be done with just about any color association and at its core, people will include the context when considering the associations. Red machines are better because they're faster, after all, even if you're not making a WH40k joke.
I think the author of the article overstates the implicitness of the associations they make with red/green and propose that everyone has such strong associations. When I read a diff, the color doesn't matter, I just need to know what it indicates. I set my terminal colors and syntax highlight colors not to indicate some specific judgement on the colors, but because I want different things to stand out so when I am scanning.
Bright red stands out well in general, so it's useful for errors so I catch it when scrolling, which typically are what I'm interested in if I'm checking a log. Based on my primary interest, I pick the other colors that are complimentary to red or opposing to help quickly categorize. With diffs, I am interested in what got the axe typically, because first I want to see "what did we have before?"; it's very difficult to judge if what was added is an improvement without knowing the context of what was replaced, so for me, it makes sense to focus on what was originally there, then see what was changed. This is naturally _my_ association and interpretation, and frankly it could work with any scheme assuming the colors were different enough.