> what do you lose by iTerm2 having an opt-in feature that you don't need to use?

Trust. “AI” features are a trust rubicon. Once you add it, the assumption is that surveillance is now baked in.