Hacker News Reader

Line 52,000 and x of what file?

I didn't find any file with that many line's yet, still searching but I doubt it exists unless it's in a different repository.

https://github.com/quickjs-ng/quickjs/blob/b071d36ab561a85fa...

Thanks for digging that up.

It looks like the mutex is theoretically sound.. unlocked before all returns, as long as there isn't an exception raised in between. I wonder what the parent comment's issue is.

Oh yeah of course its sound, but this is not how you write C code, because all it takes is for someone else in 10 years to, somewhere between 51000 and 53000 introduce an early return statement and forget to unlock that mutex, or other little things.

This is solved in C usually with a goto to a cleanup routine, and avoiding early returns.

This is C, not C++ - very different languages.

Yes, you should be using a goto for this in C

when I see C/C++ code, I prefer do not run it.