Milkshakes per se are a bit out of fashion but nowadays the fashion is "coffee shops" like Starbucks that are similar if more coffee-based.
Milkshakes are one of the most popular things Starbucks sells.
Though for unfathomable reasons they insist on adding coffee to almost all of them, as if that were the reason people buy milkshakes.