Technically, the aid sent to Israel is an American jobs program. The money that is sent there goes directly to the military-industrial complex back in the United States.
So it's a ploy to expand the military budget beyond what was allocated by Congress. Either way, that's a money sink, not an investment.
America has practiced this trick well.