Finding a label for personal problems typically results in a honeymoon of self-acceptance and relief. The honeymoon usually ends and the problems remain, but now there are possible paths forward.
The trap is trying to externalize the diagnoses as a get out of jail free card that can be used to justify avoiding hard changes and difficult work. The more difficult version of this is when someone tries to externalize the responsibilities of their diagnosis on others. I've seen a couple situations where someone got an ADHD diagnosis and then took it straight to their employers expecting to receive more forgiveness for late work and mistakes, then getting angry when it didn't change their company's expectations. It's a hard conversation to have with someone who thinks the diagnosis is going to relieve the weight of all the problems they've been facing, when in fact it's only helpful for identifying what they need to work even harder on improving and coping with.
This is one reason why I'm kind of glad I wasn't diagnosed earlier. I would have 100% done this. Now, in my 40s, there is less need for kind of thing, and less tolerance for it in a work environment anyway. I haven't told my employer and don't plan to. I just assume it would put a target on my back.
I get the impression that it’s largely the people who arrive at the diagnosis after being pulled into certain online communities. The Reddit ADHD content can be wildly out of touch with reality because it functions as a space for venting and complaining, masquerading as a space for support and helpful resources.
When I was around a lot of juniors it was surprising to me that so many of them would go through the route of getting an ADHD diagnosis and then trying to get special accommodations at work for it. A lot of the workplaces were very receptive and attempted to provide reasonable accommodations, but it wasn’t what they expected or wanted from their employers. There seemed to be a belief that getting a diagnosis was a shield from being PIPed or that it meant that the employer couldn’t judge them for performance problems.
I try use that as a motivator to not just blame my shortcomings on ADHD and instead keep pushing myself to work through them.