Generating data is good, as long as it's limited to metrics about the vehicle and its use. It can help diagnose issues. It doesn't have to leave the vehicle though. Garages can simply read it locally when required.
Error codes for faults and nothing else are enough.