In particular it's `req` in the function with this signature:
static void assign_headers(request_rec *r, const h2_request *req,
int no_body, int is_connect)
The fix being: - apr_table_setn(req->headers, "Content-Length", "0");
+ apr_table_setn(r->headers_in, "Content-Length", "0");
My read on this is that `req` is meant to be a readonly value in this function, which is why it's marked `const`. And being readonly, it would be safe to access concurrently. However, someone accidentally wrote through this pointer.In Rust this would've been `req: &h2_request` and the accidental write wouldn't have been possible (barring interior mutability). Even with interior mutability there is no thread interleaving during the write, which happens through a `&mut h2_request` probably obtained through a lock.
Where this is one such oversight, there are likely others. An LLM isn't needed to find these, likely stricter compiler flags.
https://github.com/icing/mod_h2/commit/1b468851c89cdbf6d0f98...
Looks like he made the change on the Transfer-Encoding line when he was moving things around, but missed doing the same on the Content-Length line.
To my understanding, in safe Rust to share between threads the compiler will require something like Arc<Mutex<...>> - which prevents unsynchronized access or freeing while another thread is still using it.
Sorry for you I did not meet your standards. Pfff.