And there lies the rub. A) It is entirely possible that China will screw up something in their planning resulting in poorer environmental outcomes. B) This demographic shift will almost certainly come matched with an economic uplifting, and regardless of efficiencies of scale and density (which is what a city gives you), the increase in standard of living (and therefore energy and other related 'products') can result in increased environmental damage.
It really comes down to a question of execution.