You mean a symbol of freedom not oppression.
I am aware of how jealous the Arabs are of Israel, and how they wish they could also have those freedoms. It's of course part of the reason that the Arab administrations demonize Israel so much - so that their own people don't complain about their own countries.
But that's exactly why the US should support them so strongly, this is what America was founded on. Even if there is no benefit.
> greatly increases the risk of terrorist attacks against the US.
No it doesn't. America is also a symbol of freedom, just like Israel and they hate America just fine, even without mentioning Israel.
But you are wrong about the benefits though, just for the consumer an enormous amount of technology comes out of Israel. And for America to turn away from Israel would be the same as renouncing the principles America was founded on. I hope to never see a day when America doesn't at least try to uphold these values (even if the actions aren't what they should, at least the ideal is there).
I'm sure you've head the saying about trading security for liberty. And the same is true for ideals. Sometimes you have to fight for your ideals. Even if there is a cost. The downsides of having no ideals at all is just not worth it.