Your central claim seems to be that our man JR only has authority to appoint federal judges to FISC for 7 year tenures, but cannot alter how FISC itself works, and in any case he can't stop citizens from challenging the surveillance state through all the well-known avenues. Therefore he doesn't have "exclusive, unaccountable, lifetime" power.
I agree that this characterization precludes JR from "exclusive, unaccountable, lifetime" power but I don't think it stops him from exercising a surprising amount of it. I particularly enjoyed this synopsis from Klein:
The FISA court is composed of federal judges. All are appointed by the same man. All but one hail from the same political party. And unlike judges in normal courts, FISA judges don’t hear opposing testimony or feel pressure from colleagues or the public to moderate their rulings.
The power to pick and choose who gets to interpret the laws Congress might set is quite substantial in its own right. It's true that if Congress banned all surveillance the judges would have limited power, and so too would JR's power be limited.
But on the other hand, if Congress chose some other slightly more complicated law to limit surveillance, his power would increase. For any moderately complex legal document, there is substantial latitude in how intelligent people reasonably interpret it. This allows, for example, smart SCOTUS judges to disagree quite substantially in their interpretation of the Bill of Rights. More pertinently, it allows one of the authors of the Patriot Act to ask in confusion how it enabled the current surveillance.
The power to pick and choose those who consistently swing one way or another on the question of surveillance, for whatever benign, intelligent reasons, might not be an "exclusive, unaccountable, lifetime" one, but it's substantial enough to give me pause.
You know I enjoy your comments, and my long disagreement here is a sign of respect, not antipathy.