HNHacker News
TopNewBestAskShowJobs

ghroos

3 karma · joined October 21, 2017

submissionscomments
ghroos··on Home Assistant is an open-source home automation platform running on Python 3
Sure. https://github.com/home-assistant/home-assistant/pull/9272 Closed with prejudice as a “hack.” I actually spent some time to make this feature request implementation consistent with other code as another contributor mentioned.

https://github.com/home-assistant/home-assistant/pull/9270 The second one was based on an observed defect in the UI. The defect is still there but apparently this is flippantly a “feature” now.

Disagreements about implementation aside this is not the response I’ve gotten from better maintained projects.

ghroos··on Home Assistant is an open-source home automation platform running on Python 3
Which is sad considering an issue I was attempting to contribute was a bug fix rather than new feature work. Clearly a lot of the earlier code suffers from lack of design.

As I mentioned later I have had PRs accepted but overall I find maintainership to be a real mixed bag. Better run open source projects do not have this inconsistency.

ghroos··on Home Assistant is an open-source home automation platform running on Python 3
Probably. I had a couple prs accepted by another maintainer fwiw. The code standards were not the issue, nor were unit tests. Not my first rodeo. The later interactions were not pleasant and did not engender much interest in further contribution.
ghroos··on Home Assistant is an open-source home automation platform running on Python 3
Having contributed to a number of projects via github, this is not true at all. I have had prs closed within minutes with curt replies. That is not how you “help newer devs through a PR process.” In another case this happened for a very clear bug. I’m cool with making amendments but maintainers do not seem open to that often, feeling more content to close things because they see the fix as a “hack”. Compared to other projects HASS is one of the worst I have dealt with, sorry to say.