As soon as it makes sense, you should start hosting somewhere in the cloud so you can offload at least some of the potential problems to SREs. I also found that moving your database to the cloud can be a good trade-off when running solo.
731 karma · joined October 2, 2013
As soon as it makes sense, you should start hosting somewhere in the cloud so you can offload at least some of the potential problems to SREs. I also found that moving your database to the cloud can be a good trade-off when running solo.
> 1) It's not obvious enough that a user is supposed to declare a state after writing a response
That's because you don't need to declare a state after writing a response. :) The basic workflow is simple: click the button if you're in favor of ending the discussion, otherwise write a response. For more advanced workflows, yes, you can explicitly select a disposition from the dropdown, or prefix your message with a magic keyword to do so automatically.
> For (2), this is more personal opinion, but I think comment threads are similar to Github issues in that there only need to be two states: closed or open.
You're conflating two separate things: each discussion has a state (open -> in progress, closed -> resolved in Reviewable parlance), but so does each participant. The discussion's state is a function of all the participants' states, allowing for a consensus to develop in multi-party reviews without giving any one person the power to unilaterally close the discussion. There are three basic participant states:
Blocking -> prevent discussion from resolving Satisfied -> in favor of resolving discussion Discussing -> neutral; not my monkeys, not my problem
The other two states you mentioned are specialized and affect other features besides the discussion state:
Working -> like Blocking, but also "keeps the ball in your court", so Reviewable knows you're still responsible for further progress on this discussion and won't list it as needing a reply from other participants; it's usually employed by a PR author who agrees with a request but wants to reply with further details before they've actually done the work.
Pondering -> this prevents a draft from being sent when you publish; useful for "notes to self" as you read through the code that may or may not become actual issues you want to raise, and that you don't want to accidentally publish as-is.
It's not a simple system but we figure you've got GitHub for that, so we choose to err on the side of powerful.
> My somewhat controversial opinion is that the author and reviewer should trust each other enough that the author can respond to a note and mark it resolved without awaiting confirmation from the reviewer who wrote the note.
You can do that too! If you initiate a discussion as Discussing, then if the author clicks the Done button (switching to Satisfied) the discussion will automatically be resolved, with no further input from you. You can change your default disposition for discussions created as a reviewer if that's how you prefer to work; see https://docs.reviewable.io/discussions.html#resolution-workf... for details.
> In Critique, it was easy to see at a glance whether a note was active or resolved
In Reviewable, resolved notes are collapsed into the title bar (if just resolved) or into a gutter icon (afterwards), so usually you won't even see them. I'm confused when you say that you can't tell which are active and which are resolved, but perhaps we differ in our understanding of what "resolved" means.
> Steep learning curve
Guilty as charged. I think it's cohesive and efficient once you learn it but the learning curve is quite steep. We keep trying to think of ways to flatten it a bit but haven't had any great ideas so far. If you have thoughts on this -- or could point us to a great UX designer with dev tools experience -- it would be much appreciated!
> Performance
There are some obvious things we're working towards to improve it but these days most reviews load in 3-4 seconds for me, even on a not-very-awesome laptop. What kind of platform are you seeing 10 second load times on, and how's your Internet latency to us-central? Please open an issue and we can work through it together.
> Complicated configuration
Yeah, there's a lot of support for legacy and highly customized workflows in there. But these days the primary and default integration is with GitHub's approve/request changes workflow, which gives you one-click approve -- have you tried using that? (Efficient multi-repo config updates are also on the todo list, but never quite rose to the top.)
> Excessive permissions
This is an unavoidable side-effect of using GitHub's OAuth authorization mechanism. GitHub Apps allow finer-grained permissions but they didn't exist when we created Reviewable and don't have a good answer for listing PRs, which would make our dashboard significantly less useful. We do have a transition planned out but at this point our main customers are enterprise folks who run their own GHE Server and don't much care about fine-grained permissions, so the ROI doesn't pencil out.
> Thread state is unclear
Huh, I'm surprised by this one. The basic flow is: 1. Reviewer creates a discussion (disposition defaults to Blocking). 2. Author responds with questions/comments (disposition defaults to Discussing). 3. Reviewer clarifies (disposition unchanged) or clicks the big Resolve button (disposition changes to Satisfied, discussion is resolved). 4. Author addresses the comment and clicks the big Done button (disposition changes to Satisfied). 5. Reviewer checks and, if satisfied, clicks Resolve (disposition changes to Satisfied and discussion is resolved).
Basically, at every step you either reply to keep the discussion going, or click the button to indicate that you're fine with closing it out. You shouldn't even need to care about the specific disposition unless you're trying to run more advanced workflows.
> No development
Yeah, I pretty much abandoned the blog and should probably take it down. However, we do ship new features regularly and post updates on Headway [1]. These should also pop up as the "red circle new stuff counter" in the UI, but perhaps your browser is blocking that third-party connection. (Headway only gets major feature posts, but there's a lot more work going on in the background that's only reported on the enterprise changelog [2].) I'm not a fan of spammy email newsletters so we don't send those.
Again, thanks for the feedback, and don't be a stranger -- it's easy to reach us through email, chat, issues, etc., and we respond promptly to every message. Even if we have to hunt them down on HN. :)
[1] https://headwayapp.co/reviewable-changelog [2] https://github.com/Reviewable/Reviewable/blob/master/enterpr...
All this to say that I heartily endorse the OP's strategy.
That's not true in my experience: I've been paying my GCP bill with debit cards from three different banks for years. (They were branded as VISA or Mastercard, mind you, but still debit cards.)
> According to Stephen MacFarlane, a professor of international relations, "It gives signatories justification if they take action, but it does not force anyone to act in Ukraine." [...] Regardless, the United States publicly maintains that "the Memorandum is not legally binding", calling it a "political commitment".
Hey there! Reviewable is a code review tool for GitHub pull requests that makes the process of serious reviews thorough yet efficient. It's not for everyone but the teams that need it swear by it, especially in larger companies. We're building out our team and need an experienced UX Engineer: somebody who's a bona fide Front End Engineer, as well as a strong UX/UI Designer.
We're looking for a person who combines both skillsets because it's much harder to design for an audience of developers in a highly technical domain when you're not a developer yourself.
What you'll get to do: - Have strong opinions about code review workflows and tooling, informed by using Reviewable on a daily basis and direct communication with users. - Design (and redesign) features for Reviewable, from ideation through wireframes to final layout, bouncing ideas around the team. - Collaborate on implementing those features, from prototype to production-ready code. - Launch features, get feedback, and perhaps revise your opinions <gasp>. - Own the front end architecture and become the go-to person for deep front end issues. - Own the visual design of the app and the styling / component libraries that implement it. - Contribute to setting Reviewable's direction as we grow!
Our tech stack is Vue 2.x, SemanticUI 0.19, and NodeJS backed by the Firebase RTDB and GitHub's API, all glued together with a fair bit of fancy custom libraries. You'll know some of the tech and pick up the rest quickly -- we're not worried about this.
We're a small, bootstrapped company that was run solely by its founder for a number of years but we're now growing the team to a handful of people. We're remote work natives and offer most of the usual benefits you'd find in larger companies. We move fast while keeping our code base a place we enjoy working in -- we're not afraid to bang out a feature quickly on occasion, nor are we afraid to take the time needed for a major refactoring. Most importantly, we're our own first customers, so we care intensely about keeping Reviewable's code review workflow smooth and efficient.
If this sounds like the kind of work you'd be good at and enjoy doing, please get in touch with piotr@reviewable.io! Please send evidence of your skill in both Front End Engineering (e.g., GitHub link) and UX/UI Design (e.g., a portfolio). For bonus points, tell me what annoys you most about GitHub's pull request review process!
Hey there! Reviewable is growing quickly and we're looking for an experienced Product Designer to help us continue to delight developers around the world.
Reviewable is a code review tool for GitHub pull requests that makes the process of serious reviews thorough yet efficient. It's not for everyone but the teams that need it swear by it. However, as Reviewable has grown organically over the years its design hasn't kept pace, and the most common complaint from potential users today is that the UI looks confusing and the workflow feels foreign. That's where you come in!
As the sole designer on the team, you'll be in charge of proposing and designing new features, revamping the onboarding flow, updating the app's visual design, and over time overhauling the core design of the tool to better align with user expectations. You'll also be contributing in other areas (e.g., marketing, development, customer support) as your skills and inclinations allow.
We're looking for somebody with significant product design experience, as well as experience working on developer tools or as a developer. You should be comfortable with Git, HTML, and CSS, and have great written + visual communication skills.
Reviewable is a very small bootstrapped company that I founded and ran solo for many years. We're growing steadily, though, and expanding our team as we do so. We're remote work natives, but we hope to supplement that with occasional in-person gatherings as the pandemic recedes. We move fast, unencumbered by committees or office politics; everyone reports directly to me.
Please get in touch if you find the challenge of designing developer tools intriguing and aren't afraid of leading the charge. You'll have an outsized impact on the product and ultimately help bend the company's trajectory upward!
Reviewable is a web app that makes code reviews of PRs more efficient and thorough -- think "Google Critique for GitHub". We're bootstrapped and growing, especially in the enterprise space, but this is not a VC rocketship. We're a tiny team that takes pride in shipping quickly while building a codebase that we actually enjoy working in.
We're looking to hire a mid-level UX Engineer: someone with a strong intuition for how to design a great user experience, but who is also comfortable with writing code to implement their design. You might be a front-end engineer with an untapped passion for UX, or maybe a UX specialist taking their first steps into development. We're pretty open-minded on the details but you do need to be able to improve on our current UI and workflow!
Our frontend tech stack is JS, Vue 2, Firebase RTDB, and custom libraries, so we don't really care what technology you're already familiar with since you'll need to pick up new stuff anyway. The one hard requirement is that you must have excellent written communication skills. After an initial chat or two we vet promising candidates via a short (paid) contract where we work together on a new feature and get it launched.
Anyway, I'm the founder -- ping me at piotr@reviewable.io if you think this might be a good fit!
Won't fix; working as intended.
Based on my research I wouldn't recommend using GitHub Marketplace in its current state.
It's not open source because, frankly, it's still hard to run a business on open source -- especially without VC backing (Reviewable is bootstrapped). After all these years things are still growing nicely and while I've run the show solo for a long time I started hiring full time folks in the last year or so. (If you think you might be interested to join, ping me and let me know!)
As for diffing commits, you can switch a review into "review each commit" mode so that it will create one revision per commit. You can make this the default for a repo but it's not in the demo as it's not the most common way to work. The demo does really need updating, though!
I mean, you're not wrong, but I think it's fair to note that yours is not a popular opinion [0]. :D