HNHacker News
TopNewBestAskShowJobs

ppwwyyxx

4 karma · joined November 15, 2014

my public key: https://keybase.io/ppwwyyxx; my proof: https://keybase.io/ppwwyyxx/sigs/T2qZLxIEo9hEM7mHWTqClmLjT-IgHybslDx6u0Ja9Uo
submissionscomments
ppwwyyxx··on Stacked Diffs (and why you should know about them)
The workflow you described is very hard to use in practice, for example:

1. If you edit A after reviewer comments, B will now have a dangling source. You'll need some rebase-fu to handle that, and the pain is significant if the chain is long. In stacked-diff workflow, it is handled automatically.

2. If you need to insert a new PR between A and B, or swap the order of some PRs in the chain, you'll need to manually do a lot of rebase-fu, and possibly manually updating the "target branch" on github. While in a stacked-diff workflow, all of these are handled automatically.

ppwwyyxx··on Dan Povey, Developer of Kaldi, Fired from JHU
> So essentially I am being fired for what might have happened, while the students are getting off scot free for things that actually did happen.

It was demonstrated in this exact incident.