This has now been fixed. Sorry again for the trouble!
66 karma · joined October 18, 2011
https://github.com/raycmorgan
Also as a developer, I would rather have the burden of feature changes and processing feedback than the user have to sift through release notes to determine if they should update or not. Most users probably don't read the release notes in favor of just clicking "Update All" (speculation). All in all, I would rather have all my users always up to date so I can push bug fixes, features and improvements faster.
async.eachSeries(players, askName, function (err) {});
// this is someplace it should go
function askName(player, callback) {
Ask("What's your name", function (err, name) {
if (err) { return callback(err); }
if (IsValidName(name)) {
player.name = name;
callback(null);
} else {
askName(player, callback);
}
});
}
This follows Node's err convention. Note I use a bit of old fashion recursion to handle the asking for a valid name. This will not stack overflow due to the fact Ask is async. You could inline askName, but then you wouldn't have a nice little unit testable function.