It's the ROT13 of defense mechanisms.
You have to decide if the tradeoff between a thousand bot's scans and a sole eavesdropper noticing the knocking pattern and marking your host as "(incompetently) trying to hide" is really worth it.
Edit: heh, same thing is going on a few comments down :)
Not true. Modern port knocking is provably secure and requires network layer attacks to bypass.