- ECC RAM, to avoid corruption on write
- Software RAID, to avoid data loss due to drive failure
- Some kind of checksumming and error-correcting filesystem, e.g. ZFS, to prevent data loss due to bad sectors
- Enough CPU to transcode media in real-time
- Vanilla distro with SSH, SMB filesharing, Plex, and networked printing
- A spare PSU in the closet
I explicitly avoid:
- Hardware RAID (unnecessary, expensive, harder to fix)
- Any OEM prebuilt NAS products (more expensive, less capable, less user control)
- Any specialty NAS-oriented distros or OSes (more feature bloat, bigger attack surfaces)
I use plain old Debian for my home NAS. I'd switch to OpenBSD in a heartbeat if it supported a checksumming and error-correcting filesystem.